worker_spi shouldn't execute again on sigterm

From: Jeremy Finzel <finzelj(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: worker_spi shouldn't execute again on sigterm
Date: 2018-11-28 15:55:37
Message-ID: CAMa1XUgOWqhUpHX_GKkM-YVoy6AOW0rPaRpYDbY01dyc6dtjPQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I noticed that the way the test module worker_spi is written, it will
execute the main loop SQL one more time after it gets a sigterm, THEN exit
1. This was surprising to me where I used this module as a pattern for my
own background worker as I would have thought it should bail immediately
without executing any more SQL.

Shouldn't we add something like this line before it enters the phase where
it starts the transaction and executes the SQL?

/*
* In case of a SIGTERM, exit immediately
*/
if (got_sigterm)
{
break;
}

Please help me if I'm missing something.

Thanks,
Jeremy

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Evgeniy Efimkin 2018-11-28 16:41:45 Re: [WIP] CREATE SUBSCRIPTION with FOR TABLES clause (table filter)
Previous Message Daniel Verite 2018-11-28 15:25:47 Re: Markdown format output for psql, design notes