| From: | Arvind Kandpal <arvind(dot)kandpal(at)ksolves(dot)com> |
|---|---|
| To: | Matemática A3K <matematica(dot)a3k(at)gmail(dot)com> |
| Cc: | peter(at)eisentraut(dot)org, pgsql-docs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: 4.1.4. Special Characters |
| Date: | 2026-11-05 07:31:15 |
| Message-ID: | CAM_z12iR5hKz5nwGTXgEU5dH=AmuB5LMfnwyH5bL6uVzfRAdcg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
> Hey Arvind, it LGTM with a small change: "* is a shorthand for all the
> columns of the selected rows (not including <xref
> linkend="ddl-system-columns" endterm="system columns"/>)." What do you
> think?
Thanks for the review. I like that wording better.
endterm needs the id of an element, not free text, so this form fails
the doc check. I used <link linkend="ddl-system-columns">system
columns</link> instead, which gives the same rendered text, with
"system columns" as the link.
The attached v4 has this change. The docs build cleanly with make
check and make html.
I have also added the patch to the commitfest:
https://commitfest.postgresql.org/patch/7599/
Thanks,
Arvind Kandpal
On Wed, Nov 4, 2026 at 8:18 PM Matemática A3K <matematica(dot)a3k(at)gmail(dot)com> wrote:
>
> On Tue, Nov 3, 2026 at 4:37 AM Arvind Kandpal
> <arvind(dot)kandpal(at)ksolves(dot)com> wrote:
> >
> > > I think if you want to go in that direction, you should refactor saying
> > > something like "* is the shorthand for all the user-defined columns (see
> > > system columns)". What do you think?
> >
> > Thanks for the suggestion. Changing the existing sentence is cleaner
> > than adding a new one.
> >
> > The attached v3 changes the first sentence of that paragraph on the
> > SELECT reference page to say that * is a shorthand for all the columns
> > of the selected rows, not including system columns, with a link to the
> > System Columns section. I used "not including system columns" instead
> > of "user-defined columns", since the docs don't use that term for this.
> > I also dropped the example to keep the change small.
>
> Hey Arvind, it LGTM with a small change: "* is a shorthand for all the
> columns of the selected rows (not including <xref
> linkend="ddl-system-columns" endterm="system columns"/>)." What do you
> think?
--
Arvind Kandpal
Junior Software Engineer
(+91) 9650266413 www.ksolves.com
Years of
listing on
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-doc-Mention-that-does-not-include-system-columns.patch | text/x-patch | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Matemática A3K | 2026-11-04 14:48:07 | Re: 4.1.4. Special Characters |