Re: [PATCH] Refactor pgbench to make future improvements easier

On Fri, Oct 23, 2026 at 12:28 PM Koshi Shibagaki (Fujitsu)
<shibagaki(dot)koshi(at)fujitsu(dot)com> wrote:
>
> Hi Hannu,
>
> Thank you for patches.
> I'm interested in the pgbench refactoring.

Thans you

> The current series includes code movement, changes to internal
> interfaces, and new features. To make review easier, could we focus
> this thread on moving the existing code into separate modules while
> preserving existing behavior?

The reason they are all together is that I did not want to post six or
seven separate patch sets,of increasing length, each next one
including all the previous ones to make CI happy.

And yes, I was expecting the review to take place in logical patches,
as described in the email.

> For v6, patches 0001-0007 seem like a suitable scope for that review.

yes, these should be just pure code movement with only strictly needed
additions to make this movement possible.

> I have left 0008-0012 out of this scope because they go beyond code
> movement and include changes to internal interfaces and structures.

Agreed, better leave thes out for now.

> Those changes could be discussed separately, along with the new
> features.

The logical next patch after the pure file splitting in series would
be the one extracting functions into their own file and making them
also available as an extension.

But let's discuss that once the somple file-level refactoring is done

> I'd like to help review the code movement in 0001-0007.

Yes please, absolutely.

Very much appreciated!

-----
Hannu