| From: | Hannu Krosing <hannuk(at)google(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Jan Wieck <jan(at)wi3ck(dot)info>, Dilip Kumar <dilipkumarb(at)google(dot)com> |
| Subject: | Re: Direct Toast PoC |
| Date: | 2026-07-30 11:06:39 |
| Message-ID: | CAMT0RQSCzWWc5ERRigOqi5jvxpxoyp_187Vnp5isL-bbW3Dfyg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 30, 2026 at 6:41 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> Okay, spoiler: I did look at the code, and your LLM has just been
> hard-coding a new vartag_external, plumbing it into the TOAST
> internals without caring about any concept of backward-compatibility.
If "backward-compatibility" meant the need to refactor the code for easier
extensibility I very much agree with you. Some refactoring would make the whole
thing much more pleasant to work on, and your patches did a good job at that.
Maybe we can move the cleanup/refactoring into a separate patch set
to get at least that part moving ?
I would be happy to help reviewing that
---
Hannu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shlok Kyal | 2026-07-30 11:06:42 | Re: Bug in ALTER SUBSCRIPTION ... SERVER / ... CONNECTION with broken old server |
| Previous Message | ZizhuanLiu X-MAN | 2026-07-30 11:03:42 | Fix var_eq_const: sum selectivity of all matching MCV entries instead of stopping at first match |