| From: | xiahoumuxuan(at)gmail(dot)com |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Keep git-external-diff usage text from executing |
| Date: | 2026-10-25 05:31:41 |
| Message-ID: | CAMPOERkDVZpNXVMAportWZCR8jBV-JZN9RcNuM=SROrdQ7eJvA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Daniel,
I agree with Tom's reasoning. If this has gone unnoticed for so long,
removing the script makes more sense than fixing it. I'm happy with
removal instead of my original fix. Thanks for preparing the patch.
Regards,
zmuxuny
On Sat, 24 Oct 2026 22:52:57 +0200, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 23 Oct 2026, at 05:27, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> >
> >> On 22 Oct 2026, at 22:33, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> >> So I'm rather inclined to just delete it instead of expending effort on fixing
> >> it.
> >
> > +1
>
> PFA patch removing it.
>
> --
> Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2026-10-25 06:11:06 | Re: Reject access to unlogged tables in contrib modules |
| Previous Message | Zhijie Hou | 2026-10-25 03:06:04 | Re: [PATCH] Fall back to serializing when parallel apply runs out of DSM segments |