From: | Mike Palmiotto <mike(dot)palmiotto(at)crunchydata(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: partitioned tables and contrib/sepgsql |
Date: | 2017-04-03 15:38:59 |
Message-ID: | CAMN686F8FRz80jhs5e55oTLuAg-HhdcDPhJkjBDCfc8cc6OGLA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Mar 31, 2017 at 8:23 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Mar 31, 2017 at 2:14 PM, Mike Palmiotto
> <mike(dot)palmiotto(at)crunchydata(dot)com> wrote:
>> Attached you will find two patches, which were rebased on master as of
>> 156d388 (applied with `git am --revert [patch file]`). The first gets
>> rid of some pesky compiler warnings and the second implements the
>> sepgsql handling of partitioned tables.
>
> 0001 has the problem that we have a firm rule against putting any
> #includes whatsoever before "postgres.h". This stdbool issue has come
> up before, though, and I fear we're going to need to do something
> about it.
Yeah, I recall this rule. The only things I can really think of to
solve the problem are:
1) #define _STDBOOL_H in postgres's c.h once bool and the like have
been defined, so we can avoid re-definition.
2) Enforce that any code utilizing the stdbool header manage the
re-definition with some combination of #undef/#define/#typedef and
document the issue somewhere.
I'd be more inclined to believe 2) is the correct solution, since 1)
is more of a hack than anything.
Thoughts?
>
> 0002 looks extremely straightforward, but I wonder if we could get one
> of the people on this list who knows about sepgsql to have a look?
> (Stephen Frost, Joe Conway, KaiGai Kohei...)
I welcome any and all feedback.
Thanks,
--
Mike Palmiotto
Software Engineer
Crunchy Data Solutions
https://crunchydata.com
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2017-04-03 15:41:59 | Re: delta relations in AFTER triggers |
Previous Message | Stephen Frost | 2017-04-03 15:34:52 | Re: Rewriting the test of pg_upgrade as a TAP test |