| From: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Regarding feature "Option to skip Password-Dialog for identity file" |
| Date: | 2025-09-30 05:03:04 |
| Message-ID: | CAM9w-_nQoD0WwEWwGaWCKkR1k6R+jpJdyFHSwp8RnvocMt9CBQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Akshay,
How about we prompt for password irrespective of what is the error from
sshtunnel library?
Try to connect without a password for identity file based, if any error
comes then ask for password along with displaying the error message. No
need to bother what the error is about.
On Mon, Sep 29, 2025 at 7:27 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Dave/Hackers,
>
> I am working on the feature "Option to Skip Password Dialog for Identity
> File" #6996 <https://github.com/pgadmin-org/pgadmin4/issues/6996>.
>
> I initially tried implementing it so that the tunnel password would not be
> requested upfront, and would only be prompted on error. However, the
> *sshtunnel* library currently returns a generic error message, for which
> I have created an issue on the SSHTunnel GitHub repository #305
> <https://github.com/pahaz/sshtunnel/issues/305>.
>
> This approach introduces multiple scenarios for when to prompt for the
> tunnel password, making the code more complex and harder to maintain.
>
> *Proposed solution:*
> Add a new switch *"Prompt for password?"* in the server dialog under the
> *SSHTunnel* tab. By default, the switch is set to *false* and is enabled
> only when the authentication method is *Identity File*. See the
> screenshot below for reference.
> [image: Screenshot 2025-09-29 at 7.12.17 PM.png]
>
> Thoughts/suggestions?
>
>
> Akshay Joshi
>
> Principal Engineer | Engineering Manager | pgAdmin Hacker
>
> enterprisedb.com
>
> * Blog*: https://www.enterprisedb.com/akshay-joshi
> * GitHub*: https://github.com/akshay-joshi
> * LinkedIn*: https:// <http://goog_373708537>
> www.linkedin.com/in/akshay-joshi-a9317b14
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
<https://www.enterprisedb.com/>
"Don't Complain about Heat, Plant a TREE"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2025-09-30 05:46:28 | Re: Regarding feature "Option to skip Password-Dialog for identity file" |
| Previous Message | Akshay Joshi | 2025-09-29 13:57:23 | Regarding feature "Option to skip Password-Dialog for identity file" |