Just a quick ping on this patch.
It appears the `tts_tid` assignment was inadvertently omitted from the
BufferHeapTupleTableSlot path in ExecForceStoreHeapTuple() when the
function was first introduced during the PG12 TupleTableSlot
refactoring [1].
This was subsequently exposed when the GiST index scan reorder queue
was updated to route popped tuples through this same function [2]. The
relevant code hasn't changed since those commits.
Thanks,
Virender
[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=4da597edf1b
[2] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=b8b94ea129f