| From: | Nikolay Samokhvalov <nik(at)postgres(dot)ai> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org>, Andrey Borodin <amborodin(at)acm(dot)org>, Kirk Wolak <wolakk(at)gmail(dot)com> |
| Subject: | Re: Add --system-identifier / -s option to pg_resetwal |
| Date: | 2025-06-04 18:46:21 |
| Message-ID: | CAM527d-D+XyyQxy+pzyu_RhpP=Q_qz69d__Gzdbaynas-8Yeeg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thank you, Peter and Michael, for the reviews
Attached is v2, simplified as suggested:
- Removed short option -s
- Removed interactive confirmation and --force
- Simplified tests leaving only essential ones
Additionally, there was an off-list review done by Andrey Borodin, so his
comments also addressed:
- Simplified logic, getting rid of '-' check (negative numbers) -- decided
to accept negative input values (they wrap to valid positive uint64)
Nik
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-pg_resetwal--system-identifier.patch | application/octet-stream | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-06-04 18:53:27 | Re: Add log_autovacuum_{vacuum|analyze}_min_duration |
| Previous Message | Robert Haas | 2025-06-04 18:39:17 | Re: pgsql: postgres_fdw: Inherit the local transaction's access/deferrable |