| From: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][Patch]: RM1739 - Don't show Upload File icon unless it is not in capabilities [Storage Manager] |
| Date: | 2016-10-07 06:03:26 |
| Message-ID: | CAM5-9D81MtwXQWCfx+EY7Qj5NPuSOb4g9XP8zOsy7MjsWA20Jg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
*Issue:*
When clicked on upload icon while saving a file prompt user to leave page.
It is because the icon is a button and its type is set to submit which
makes it to prompt, instead it should be 'button'
Storage Manager's menu items depends on capabilities list set by the module
using it. If capabilities doesn't have 'upload' in it, It won't work.
Upload button is bound to click event only when it is in capabilities.
*Solution:*
As upload button is being added only when it is in capabilities, so upload
button html is removed from html file. It will not shown on UI untill it is
in capabilities list.
Please find attached patch and review.
Thanks,
Surinder Kumar
| Attachment | Content-Type | Size |
|---|---|---|
| RM1739.patch | application/octet-stream | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Surinder Kumar | 2016-10-07 07:48:41 | [pgAdmin4][Patch]: Listing of files/folders not sorted alphabetically in Storage Manager |
| Previous Message | Dave Page | 2016-10-06 12:42:16 | Re: Running pgadmin4 as desktop application |