| From: | Kevin K Biju <kevinkbiju(at)gmail(dot)com> |
|---|---|
| To: | Soumya S Murali <soumyamurali(dot)work(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Allowing ALTER COLUMN TYPE for columns in publication column lists |
| Date: | 2026-01-13 13:14:45 |
| Message-ID: | CAM45KeF9O8DmrahqHSRgzdNySkkT=F5aRXUSLU=-HVNggypntg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Soumya,
Thanks for testing. I had a look at the test failures, and after commit
67c20979 [1], a warning for creating a publication is only issued when the
wal_level is set to minimal. I've updated the test output to reflect this
and attached v2 of the patch.
Regards,
Kevin
On Mon, Jan 5, 2026 at 4:53 PM Soumya S Murali <soumyamurali(dot)work(at)gmail(dot)com>
wrote:
> Hi,
>
> I tested this patch on my current branch.
> The patch applied cleanly and all relevant regression tests got
> passed, including publication, subscription, dependency, and ALTER
> TABLE coverage. The behavior matches the intended semantics: ALTER
> COLUMN TYPE is allowed for columns used only in publication column
> lists, while remaining blocked when the column is referenced in a row
> filter.
> I see a failure in the rules regression test in my environment, but
> this also occurs without the patch and this appears unrelated.
> From my testing, the patch looks correct and ready for further review.
> Please let me know if any further testing or clarification would be
> helpful.
>
>
> Regards
> Soumya
>
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Allow-ALTER-COLUMN-TYPE-for-publication-column-li.patch | application/octet-stream | 10.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2026-01-13 13:26:37 | Re: Adding basic NUMA awareness |
| Previous Message | Fujii Masao | 2026-01-13 13:09:49 | Re: [PATCH] Expose checkpoint reason to completion log messages. |