| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Claudio Freire <klaussfreire(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Tuplesort merge pre-reading |
| Date: | 2016-09-11 22:34:17 |
| Message-ID: | CAM3SWZTQtbDBGV5w5CkxokrPivvRmALmc9HMCP4wbu1AouiqFg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Sep 11, 2016 at 3:13 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> * Please make this use the ".., + 1023" natural rounding trick that is
> used in the similar traces that are removed:
>
>> +#ifdef TRACE_SORT
>> + if (trace_sort)
>> + elog(LOG, "using %d kB of memory for read buffers in %d tapes, %d kB per tape",
>> + (int) (state->availMem / 1024), maxTapes, (int) (per_tape * BLCKSZ) / 1024);
>> +#endif
Also, please remove the int cast, and use INT64_FORMAT. Again, this
should match existing trace_sort traces concerning batch memory.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2016-09-11 22:56:46 | Typo in filename identification |
| Previous Message | Michael Paquier | 2016-09-11 22:23:21 | Re: Useless dependency assumption libxml2 -> libxslt in MSVC scripts |