Re: tuplesort_gettuple_common() and *should_free argument

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tuplesort_gettuple_common() and *should_free argument
Date: 2016-12-08 20:30:52
Message-ID: CAM3SWZSu8ey48y7vky_k5UTVSYu77cS2Fuhb+k+WTTC4KNp0SQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Dec 7, 2016 at 11:55 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> Should we be worried about breaking the API of tuplesort_get* functions?
> They might be used by extensions. I think that's OK, but wanted to bring it
> up. This would be only for master, of course, and any breakage would be
> straightforward to fix.

I don't think so. I'm not aware of any third party extensions that
call tuplesort.c routines, despite having looked for them. I noticed
that pg_repack doesn't. For any that do, they'll break in a
predictable, obvious way.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2016-12-08 20:41:06 Re: pg_dump vs. TRANSFORMs
Previous Message Robert Haas 2016-12-08 20:04:57 Re: Parallel execution and prepared statements