| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgindent-polluted commits |
| Date: | 2016-01-13 20:03:43 |
| Message-ID: | CAM3SWZSrGsLYv6KrWUQUeHf-Q4RtOz_-gvw-DyO+tDoj0ChVbQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 13, 2016 at 9:13 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I'm willing to go with the "separate commit to reindent individual files"
> approach if there's a consensus that that makes for a cleaner git history.
> But I'm not 100% convinced it matters.
I recently changed the configuration of my text editor to
automatically use the "git blame" whitespace flag when using its git
plugin. I did this because there was a tendency for pgindent commits
to freeze everything for several seconds when I made the mistake of
looking at a pgindent commit diff. This approach seems to work nicely,
without any downside that I've noticed.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-01-13 20:05:51 | Re: pg_dump and premature optimizations for objects not to be dumped |
| Previous Message | David Rowley | 2016-01-13 19:24:19 | Re: WIP: Covering + unique indexes. |