| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Gregory Smith <gregsmithpgsql(at)gmail(dot)com> |
| Subject: | Re: Last Commitfest patches waiting review |
| Date: | 2014-10-09 19:25:05 |
| Message-ID: | CAM3SWZSdNysZH98KujQAF6BFL4LwHi82evKj1MacjVWJOpgsFg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 9, 2014 at 12:14 PM, Heikki Linnakangas
<hlinnakangas(at)vmware(dot)com> wrote:
> B-tree index build uses tuplesort.c. What's missing?
I don't think that all that much is missing. Tuplesort expects to work
with an index scankey when sorting B-Tree tuples. There needs to be
something like a reverse lookup of the sortsupport function. It looks
like a historical oversight, that would take time to fix, but wouldn't
be particularly challenging. You'd need to pick out the operators from
the scankey, so you'd have something like what tuplesort_begin_heap()
starts off with with tuplesort_begin_index_btree().
copytup_index() would then later need to be modifed to make
abbreviation occur there too, but that's no big deal.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2014-10-09 19:36:39 | schema-only -n option in pg_restore fails |
| Previous Message | Heikki Linnakangas | 2014-10-09 19:16:00 | Re: pgbench throttling latency limit |