Re: Trivial heap_finish_speculative() error message inaccuracy

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Trivial heap_finish_speculative() error message inaccuracy
Date: 2015-11-04 03:14:44
Message-ID: CAM3SWZSYEnK76-GDYd1cakNpY96FgTWeH3YL2MPBh-ec9wE4bA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 3, 2015 at 7:10 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> This seems like a fine teaching moment in which to point out our
> longstanding error message style guideline that says not to put
> names of C functions into error messages in the first place.

I don't ordinarily do that, of course, but I thought it was important
to be consistent with other such elog() calls within heapam.c. I think
that there at least 10 that look like this.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2015-11-04 03:19:48 Re: Freeze avoidance of very large table.
Previous Message Tom Lane 2015-11-04 03:10:08 Re: Trivial heap_finish_speculative() error message inaccuracy