Re: failures with tuplesort and ordered set aggregates (due to 5cefbf5a6c44)

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: failures with tuplesort and ordered set aggregates (due to 5cefbf5a6c44)
Date: 2015-03-04 18:55:47
Message-ID: CAM3SWZRwwg_gyX0eJSjgsAWnrc7LUYgZSucMcVRtOk8r_SAJbw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 4, 2015 at 8:26 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I think we should commit my patch, and if a future patch needs
> sortKeys set in more places, it can make that change itself. There's
> no reason why it's needed with the code as it is today, and no reason
> to let bits of future changes leak into a bug-fix patch.

It's not as if I feel strongly about it. It's trivial to change the
code to make the comment true, rather than change the comment to make
the code true, and we need to do so anyway. I defer to you.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2015-03-04 18:58:52 Re: Reduce pinning in btree indexes
Previous Message Heikki Linnakangas 2015-03-04 18:41:45 Re: MD5 authentication needs help