| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
| Date: | 2015-05-21 02:42:58 |
| Message-ID: | CAM3SWZRjSZwYuVf-9GX6Axu1f51rGEwJ0RmC-j9cncQJG9ZngA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, May 20, 2015 at 6:12 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> You realize there's other instances of this in the same damn function?
I was misled by the argument name, "parsetree" -- in the past,
CreateCommandTag() actually only processed raw parse trees. Beyond
that, I wasn't aware that it is possible to produce a command tag for
every possible representation of an optimizable statement at every
stage of query processing.
I guess that I'll know next time I add a command tag.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2015-05-21 04:57:20 | pgsql: Make recovery_target_action = pause work. |
| Previous Message | Peter Geoghegan | 2015-05-21 02:08:46 | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2015-05-21 03:00:37 | Re: Typo in tablecmds.c |
| Previous Message | Robert Haas | 2015-05-21 02:38:17 | Re: RFC: Non-user-resettable SET SESSION AUTHORISATION |