Re: Invalid indexes should not consume update overhead

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Greg Stark <stark(at)mit(dot)edu>, Tomasz Ostrowski <tometzky+pg(at)ato(dot)waw(dot)pl>, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: Invalid indexes should not consume update overhead
Date: 2016-07-17 03:38:15
Message-ID: CAM3SWZRHPmTZjrvciY+u6NLJfLV=fiWbgVHbdzpVxA7=gfVVyw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sat, Jul 16, 2016 at 5:58 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Greg Stark <stark(at)mit(dot)edu> writes:
>> The real solution imho is to actually clean up failed index builds when a
>> build fails. That's what normal transactions do when they abort after all.
>> This was always the intention but looked like it was going to be a pain and
>> was put off (ie I was lazy). It's probably just several layers of
>> PG_TRY/PG_CATCH and closing the failed transactions and opening new ones.
>
> No, that wouldn't fix it if the reason the build failed was a crash.

Could we just have crash recovery perform clean-up to cover that case?

--
Peter Geoghegan

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Amit Kapila 2016-07-17 05:14:37 Re: BUG #14150: Attempted to delete invisible tuple
Previous Message digoal 2016-07-17 03:03:16 BUG #14253: b-tree no index range scan?