Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.
Date: 2015-05-22 00:51:57
Message-ID: CAM3SWZRHJ0AsPt2T1Jnr-DGBz75SizW50rWDh-+A9VnJ65PDUg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, May 21, 2015 at 5:48 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
>> If the number is useful, then perhaps we should distinguish the cases;
>> and if it's not useful, why not just return zero?
>
> There's libraries/frameworks checking if an insert succeeded by looking
> at that number, and it seems like a bad idea to needlessly break those.

+1

> So I think we're good with ripping it out. Peter?

I'll come up with a patch.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-05-22 08:06:18 pgsql: At promotion, don't leave behind a partial segment on the old ti
Previous Message Andres Freund 2015-05-22 00:48:11 Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2015-05-22 02:19:09 Re: pg_upgrade cleanup
Previous Message Jan Bilek 2015-05-22 00:49:39 Re: Postgres and TLSv1.2