Re: Bug in jsonb minus operator

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug in jsonb minus operator
Date: 2015-05-19 02:52:04
Message-ID: CAM3SWZRGgqS5DeQLhh4yE9eEFvb6JxzNFKnGN7a3jYRaCc-TyA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 18, 2015 at 7:11 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Here's an patch along those lines. It seems to do the trick, at least for
> your test case, and it has the merit of being very small, so small I'd like
> to backpatch it - accepting jbvBinary as is in pushJsonbValue seems like a
> bug to me.

Isn't that for the benefit of raw scalar pseudo arrays? The existing
comments above pushJsonbValue() acknowledge such callers.

Why are you passing the skipNested variable to JsonbIteratorNext()
within jsonb_delete()? I'm not seeing a need for that.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-05-19 03:03:18 Re: a few thoughts on the schedule
Previous Message Andres Freund 2015-05-19 02:41:51 Re: a few thoughts on the schedule