Re: RLS feature has been committed

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Brightwell, Adam" <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Yeb Havinga <yeb(dot)havinga(at)portavita(dot)nl>
Subject: Re: RLS feature has been committed
Date: 2014-09-22 23:22:08
Message-ID: CAM3SWZR4OTxyYHr7dj1SVN_dNsaGa+5Aartz4wQFMw3XEpgBZA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Mon, Sep 22, 2014 at 4:02 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> This patch has been pushed in a clear violation of established policy.
>
> Fundamental pieces of the patch have changed *after* the commitfest
> started. And there wasn't a recent patch in the commitfest either - the
> entry was moved over from the last round without a new patch. It didn't
> receive independent review (Robert explicitly said his wasn't a full
> review). It wasn't marked ready for committer. The intention to commit
> wasn't announced publically. There were *clear* and unaddressed
> objections to committing the patch as is, by a committer (Robert)
> nonetheless.

I have no reason to doubt your version of events here (although
Stephen may wish to address what you've said - I'm basing that on his
tone elsewhere). I must ask, though: what do you propose to do about
it in this instance? He has been chastised. Would you like to make a
point of formalizing what are (if I'm not mistaken) currently defacto
rules? Should RLS be reverted, and revisited in a future CF?

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2014-09-22 23:46:14 Re: Should we excise the remnants of borland cc support?
Previous Message Petr Jelinek 2014-09-22 23:20:50 Re: Anonymous code block with parameters