Re: Free indexed_tlist memory explicitly within set_plan_refs()

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Free indexed_tlist memory explicitly within set_plan_refs()
Date: 2015-07-12 21:41:21
Message-ID: CAM3SWZR2WFn+bgY4R+TchvzQndi9xV=ABpM176n8SuLyy+c_FQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jul 12, 2015 at 1:45 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> But that's more crummy API's fault than yours.

As you probably noticed, the only reason the p_is_update and
p_is_insert fields exist is for transformAssignedExpr() -- in fact, in
the master branch, nothing checks the value of p_is_update (although I
suppose a hook into a third-party module could see that module test
ParseState.p_is_update, so that isn't quite true).

> I'm right now not really coming up with a better idea how to fix
> this. So I guess I'll apply something close to this tomorrow.

Sounds good.

--
Peter Geoghegan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2015-07-12 22:05:28 Re: PostgreSQL 9.5 Alpha 1 build fail with perl 5.22
Previous Message Adam Brightwell 2015-07-12 21:20:15 Re: One question about security label command