Windows buildfarm animals are still not happy with abbreviated keys patch

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Windows buildfarm animals are still not happy with abbreviated keys patch
Date: 2015-01-21 19:30:41
Message-ID: CAM3SWZQqcDc5b20-6EsdK_sBpGpFS08RVLJTT6jc+2f5+xHwFg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Even following Robert's disabling of abbreviated keys on Windows,
buildfarm animals hamerkop, brolga, currawong and bowerbird remain
unhappy, with failing regression tests for "collate" and sometimes
(but not always) "aggregates". Some of these only use the C locale.

I think that "aggregates" does not fail for brolga because it's built
without "locale_t" support (not sure how to interpret MSVC "configure"
output, but I think that the other animals do have such support). So
maybe this code being executed within btsortsupport_worker(), for the
C locale on Windows is at issue (note that abbreviation is still
disabled):

tss->locale = pg_newlocale_from_collation(collid);

That doesn't explain the other problems, though.
--
Peter Geoghegan

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2015-01-21 19:40:47 Re: proposal: lock_time for pg_stat_database
Previous Message Tom Lane 2015-01-21 18:37:35 Re: pg_stat_statements vs escape_string_warning