Re: Last Commitfest patches waiting review

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Gregory Smith <gregsmithpgsql(at)gmail(dot)com>
Subject: Re: Last Commitfest patches waiting review
Date: 2014-10-06 18:53:27
Message-ID: CAM3SWZQhTk5OKWRu5-e=zPkWtpBVMF1Xp6M824+RY+s3Xa+5Gw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 6, 2014 at 11:27 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Well, really, I was just suggesting that I can spend more time on the
> patch, but not immediately.

We haven't really talked about the idea of the HyperLogLog-based abort
mechanism - the actual cost model - even though I thought we'd have
discussed that extensively by now. Maybe I'm reading too much into
that, but my guess is that that's because it's a particularly hard
thing to have an opinion on. I think that It might not be a bad idea
to have another opinion on that in particular.

We've historically resisted this kind of special case optimization,
and yet the optimization is likely to be very effective in many
representative cases. Plus, some aspects of the cost model are a bit
fuzzy, in a way that things in the executor ordinarily are not, and so
I can understand how this would present any reviewer with difficulty.

By the way, the original description of this approach to accelerating
sorts I saw was here, in this 2001 paper:

http://lgis.informatik.uni-kl.de/archiv/wwwdvs.informatik.uni-kl.de/courses/DBSREAL/SS2001/Vorlesungsunterlagen/Implementing_Sorting.pdf

(Under "2.4 Cache-optimized techniques")
--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-10-06 19:04:57 Re: copy.c handling for RLS is insecure
Previous Message Stephen Frost 2014-10-06 18:49:49 Re: copy.c handling for RLS is insecure