|From:||Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>|
|To:||Dilip Kumar <dilipbalaut(at)gmail(dot)com>|
|Cc:||David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: Partition-wise aggregation/grouping|
|Views:||Raw Message | Whole Thread | Download mbox|
Attached new patch-set here. Changes include:
1. Added separate patch for costing Append node as discussed up-front in the
2. Since we now cost Append node, we don't need
GUC. So removed that. The remaining patch hence merged into main
3. Updated rows in test-cases so that we will get partition-wise plans.
On Wed, Oct 18, 2017 at 9:53 AM, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> On Tue, Oct 17, 2017 at 10:44 PM, Jeevan Chalke
> <jeevan(dot)chalke(at)enterprisedb(dot)com> wrote:
> > I didn't get what you mean by regression here. Can you please explain?
> > I see that PWA plan is selected over regular plan when enabled on the
> > of costing.
> > Regular planning need a Result node due to which costing increases where
> > PWA don't need that and thus wins.
> Sorry for not clearly explaining, I meant that with normal plan
> execution time is 263.678 ms whereas with PWA its 339.929 ms.
> I only set enable_partition_wise_agg=on and it switched to PWA and
> execution time increased by 30%.
> I understand that the this is the worst case for PWA where
> FinalizeAggregate is getting all the tuple.
> Dilip Kumar
> EnterpriseDB: http://www.enterprisedb.com
Technical Architect, Product Development
The Enterprise PostgreSQL Company
|Next Message||Peter Eisentraut||2017-10-27 11:03:10||Re: inconsistency in process names - bgworker: logical replication launcher|
|Previous Message||Etsuro Fujita||2017-10-27 11:00:38||Re: Add support for tuple routing to foreign partitions|