| From: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
|---|---|
| To: | Marko Tiikkaja <marko(at)joh(dot)to> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Merlin Moncure <mmoncure(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PL/pgSQL, RAISE and error context |
| Date: | 2013-09-17 08:58:44 |
| Message-ID: | CAM2+6=Xv0WrmK+M2ZgBO0vvaO59AXti5TgEkfwoB2Upxbzb54Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Marko,
I have reviewed this patch.
1. Patch applies well.
2. make and make install is fine
3. make check is fine too.
But as Peter pointed out plperl regression tests are failing.
I just did grep on .sql files and found following files which has RAISE
statement into it. These files too need expected output changes. Please run
these testcases to get diffs.
./src/pl/plperl/sql/plperl_elog.sql
./src/pl/plpython/sql/plpython_error.sql
./src/pl/plpython/sql/plpython_setof.sql
./src/pl/plpython/sql/plpython_quote.sql
./contrib/sepgsql/sql/label.sql
./contrib/sepgsql/sql/ddl.sql
Code changes looks fine to me.
Thanks
--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rushabh Lathia | 2013-09-17 09:03:04 | Re: insert throw error when year field len > 4 for timestamptz datatype |
| Previous Message | Alexander Korotkov | 2013-09-17 08:58:42 | Re: GIN improvements part 1: additional information |