Re: Reopen logfile on SIGHUP

From: Greg Stark <stark(at)mit(dot)edu>
To: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Reopen logfile on SIGHUP
Date: 2018-02-27 22:32:41
Message-ID: CAM-w4HPuvKe_UyfgfhooVMX=+EYGp=+okjy8_Fo2koBL0fggMg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 27 February 2018 at 14:41, Anastasia Lubennikova
<a(dot)lubennikova(at)postgrespro(dot)ru> wrote:

> Small patch in the attachment implements logfile reopeninig on SIGHUP.
> It only affects the file accessed by logging collector, which name you can
> check with pg_current_logfile().

HUP will cause Postgres to reload its config files. That seems like a
fine time to reopen the log files as well but it would be nice if
there was also some way to get it to *just* do that and not reload the
config files.

I wonder if it would be easiest to just have the syslogger watch for
some other signal as well (I'm guessing the the syslogger doesn't use
relcache invalidations so it could reuse USR1 for example). That would
be a bit inconvenient as the admins would have to find the syslogger
and deliver the signal directly, rather than through the postmaster
but it would be pretty easy for them.

--
greg

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2018-02-27 22:33:08 Re: pgsql: Avoid valgrind complaint about write() of uninitalized bytes.
Previous Message Tom Lane 2018-02-27 22:14:04 Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly