From: | Greg Stark <stark(at)mit(dot)edu> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Thinking about EXPLAIN ALTER TABLE |
Date: | 2018-12-10 23:53:50 |
Message-ID: | CAM-w4HP-_kQYzKsyDAzXHoUVNdni+e_rs0kYfvQ4wN0NOPOL2w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, 10 Dec 2018 at 12:27, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>
> An event trigger with a table_rewrite event, allows you to scan a whole script for objectionable activity on a test server before you put it into production.
>
> Perhaps we just need a few extra events.
That's not a bad idea at all. Offhand the missing events that come to mind are:
1. Validation passes
1. Table Rebuild pass
1. Index builds
1. Locks that block DDL (currently that's AccessExclusiveLock and
ShareRowExclusiveLock)
I see this as complementary to EXPLAIN ALTER TABLE rather than
replacing it. EXPLAIN would help the developer understand what their
commands were doing and why during development and the event triggers
would serve largely as safety backstop in staging and production to
ensure nothing slips through.
--
greg
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-12-11 01:43:17 | Re: Add timeline to partial WAL segments |
Previous Message | Alexander Korotkov | 2018-12-10 22:50:46 | Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock |