| From: | Greg Stark <stark(at)mit(dot)edu> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [COMMITTERS] pgsql: Add some isolation tests for deadlock detection and resolution. |
| Date: | 2016-02-13 13:41:29 |
| Message-ID: | CAM-w4HOuJPZKN4cgSq8d=8t078X3epXUy1jTTnSDp3vUyv9MJg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
The tests worked fine on faster build animals, right? And the clobber
animals are much much slower.... So it seems perfectly sensible that their
deadlock timeout would just have to be much much higher to have the same
behaviour. I see nothing wrong in just setting deadlock timeout to a minute
or more on these machines.
The invariant is just that the deadlock timeout needs enough head room over
the actual time the tester's queries take. If they normally take a 1/10th
of a second then why not just set the timeout to 10x however long they take
on the clobber animals?
--
Greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-02-13 14:54:07 | Re: [COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring. |
| Previous Message | Simon Riggs | 2016-02-13 11:40:09 | Re: [COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-02-13 13:43:59 | Re: GinPageIs* don't actually return a boolean |
| Previous Message | Andres Freund | 2016-02-13 13:39:47 | Re: Defaults for replication/backup |