| From: | Greg Stark <stark(at)mit(dot)edu> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Xi Wang <xi(dot)wang(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [RFC] overflow checks optimized away |
| Date: | 2013-11-29 20:06:07 |
| Message-ID: | CAM-w4HOeKBJ_Sf6NdHV3XrZxaPBKCEegjYOKR5EeRfMLt+6xNw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 29, 2013 at 7:39 PM, Greg Stark <stark(at)mit(dot)edu> wrote:
>
> Just as an update I did get gcc to do the wrong thing on purpose. The
> only overflow check that the regression tests find missing is the one
> for int8abs() ie:
Also, one of the places GCC warns about optimizing away an overflow
check (with -fno-wrapv) is inside the localtime.c file from the tz
library. I fixed it in my patch but in fact I checked and it's already
fixed upstream so I'm wondering whether you expect to merge in an
updated tz library? Is there anything surprising about the process or
do you just copy in the files? Would you be happy for someone else to
do it?
--
greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-11-29 20:13:51 | Re: lock on object is already held |
| Previous Message | Andres Freund | 2013-11-29 19:58:06 | Re: MultiXact truncation, startup et al. |