| From: | Greg Stark <stark(at)mit(dot)edu> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amul Sul <sulamul(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal for internal Numeric to Uint64 conversion function. |
| Date: | 2022-03-17 19:46:34 |
| Message-ID: | CAM-w4HO_YOJK113fu8-tHS=-dcZLs_bieOWjXMbJBvrDG1uJYg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 11 Mar 2022 at 15:17, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Amul Sul <sulamul(at)gmail(dot)com> writes:
> > Yeah, that's true, I am too not sure if we really need to refactor
> > all those; If we want, I can give it a try.
>
> The patch as-presented isn't very compelling for
> lack of callers of the new function
Tom, are you saying you think we're not interested in just adding this
function unless it's part of this refactoring?
Amul, do you think if we did numeric_to_int64/numeric_to_uint64 as a
refactored API and a second patch that made numeric_pg_lsn and other
consumers use it it would clean up the code significantly?
--
greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2022-03-17 19:58:10 | Re: proposal: enhancing plpgsql debug API - returns text value of variable content |
| Previous Message | Justin Pryzby | 2022-03-17 19:41:30 | Re: refactoring basebackup.c (zstd workers) |