From: | Greg Stark <stark(at)mit(dot)edu> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Remove trailing newlines from pg_upgrade's messages |
Date: | 2022-06-20 18:29:25 |
Message-ID: | CAM-w4HOUFceDPSu5U0oqMeJg9ApBXvf5ePtT5WTCDjxOK2XHqA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, 15 Jun 2022 at 11:54, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Yeah, that is sort of the inverse problem. I think those are there
> to ensure that the text appears on a fresh line even if the current
> line has transient status on it. We could get rid of those perhaps
> if we teach pg_log_v to remember whether it ended the last output
> with a newline or not, and then put out a leading newline only if
> necessary, rather than hard-wiring one into the message texts.
Is the problem that pg_upgrade doesn't know what the utilities it's
calling are outputting to the same terminal?
Another thing I wonder is if during development and testing there
might have been more output from utilities or even the backend going
on that are
not happening now.
--
greg
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-06-20 18:57:08 | Re: Remove trailing newlines from pg_upgrade's messages |
Previous Message | David G. Johnston | 2022-06-20 17:59:04 | Re: Assorted small doc patches |