Re: [PATCH] minor reloption regression tests improvement

From: Greg Stark <stark(at)mit(dot)edu>
To: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] minor reloption regression tests improvement
Date: 2022-03-07 17:04:49
Message-ID: CAM-w4HODaFSVjz0R4XMYeN+bbEhcq0=H-hwq3TLSL-OriiUHpA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I don't think this is worth spending time adding tests for. I get what
you're saying that this is at least semi-intentional behaviour and
desirable behaviour so it should have tests ensuring that it continues
to work. But it's not documented behaviour and the test is basically
testing that the implementation is this specific implementation.

I don't think the test is really a bad idea but neither is it really
very useful and I think it's not worth having people spend time
reviewing and discussing. I'm leaning to saying this patch is
rejected.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhihong Yu 2022-03-07 17:42:26 refreshing query id for pg_stat_statements based on comment in sql
Previous Message David G. Johnston 2022-03-07 16:58:22 Re: role self-revocation