| From: | "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Optimizing Node Files Support |
| Date: | 2023-03-20 19:56:04 |
| Message-ID: | CAM-w4HNGbHHGQjOgqdmidF4hzZmek--BKR7Xx3jfE8oKEtr=9w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I think it's clear we aren't going to be taking this patch in its
current form. Perhaps there are better ways to do what these files do
(I sure think there are!) but I don't think microoptimizing the
copying is something people are super excited about. It sounds like
rethinking how to make these functions more convenient for programmers
to maintain reliably would be more valuable.
I guess I'll mark it Returned with Feedback -- if there are
significant performance gains to show without making the code harder
to maintain and/or a nicer way to structure this code in general then
we can revisit this.
--
Gregory Stark
As Commitfest Manager
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gregory Stark (as CFM) | 2023-03-20 20:01:02 | Re: Inconsistency in reporting checkpointer stats |
| Previous Message | Egor Rogov | 2023-03-20 19:54:24 | Re: pg_stats and range statistics |