| From: | Greg Stark <stark(at)mit(dot)edu> |
|---|---|
| To: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Window Function "Run Conditions" |
| Date: | 2022-03-15 21:23:40 |
| Message-ID: | CAM-w4HN7D1wgTnKqUEnjie=E_6kJRC08CuGTLQgSirFPo3kY6A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
This looks like an awesome addition.
I have one technical questions...
Is it possible to actually transform the row_number case into a LIMIT
clause or make the planner support for this case equivalent to it (in
which case we can replace the LIMIT clause planning to transform into
a window function)?
The reason I ask is because the Limit plan node is actually quite a
bit more optimized than the general window function plan node. It
calculates cost estimates based on the limit and can support Top-N
sort nodes.
But the bigger question is whether this patch is ready for a committer
to look at? Were you able to resolve Andy Fan's bug report? Did you
resolve the two questions in the original email?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2022-03-15 21:41:49 | Re: [PATCH] Accept IP addresses in server certificate SANs |
| Previous Message | Mark Dilger | 2022-03-15 20:59:08 | Re: Granting SET and ALTER SYSTE privileges for GUCs |