From: | Greg Stark <stark(at)mit(dot)edu> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Kevin Grittner <kgrittn(at)mail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Parser Cruft in gram.y |
Date: | 2012-12-20 15:58:12 |
Message-ID: | CAM-w4HM5Pcka3tDTtXACUXNz5qYxAnbbMhq8Fgf1ttR2=yx3og@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Dec 20, 2012 at 3:18 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Greg Stark <stark(at)mit(dot)edu> writes:
>> But I'm not entirely convinced any of this is actually useful. Just
>> becuase the transition table is large doesn't mean it's inefficient.
>
> That's a fair point. However, I've often noticed base_yyparse() showing
> up rather high on profiles --- higher than seemed plausible at the time,
> given that its state-machine implementation is pretty tight. Now I'm
> wondering whether that isn't coming from cache stalls from trying to
> touch all the requisite parts of the transition table.
For what it's worth the bloat isn't in the parser transition table at all:
516280 yy_transition
147208 yytable
147208 yycheck
146975 base_yyparse
17468 yypact
9571 core_yylex
8734 yystos
8734 yydefact
Unless I'm confused yy_transition is in fact the *lexer* transition
table. I'm not sure how to reconcile that with the profiling results
showing the cache misses in base_yyparse() though.
--
greg
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2012-12-20 15:58:32 | Re: operator dependency of commutator and negator, redux |
Previous Message | Robert Haas | 2012-12-20 15:55:27 | Re: Set visibility map bit after HOT prune |