| From: | Alexander Kuzmenkov <akuzmenkov(at)tigerdata(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix uninitialized xl_running_xacts padding |
| Date: | 2026-03-11 11:07:58 |
| Message-ID: | CALzhyqzLh9iciLMvT9T-Z+o1ekOPpeP2p2r7tYXNZ8JMSea3Zg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 11, 2026 at 11:45 AM Alexander Kuzmenkov
<akuzmenkov(at)tigerdata(dot)com> wrote:
>
> On Tue, Mar 10, 2026 at 11:09 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> > +1 for initializing all padding in WAL records. In fact I thought that
> > we already did that. (Except in this case, apparently)
>
> I found 42 exceptions like this. See the attached patch, it
> initializes some WAL records and removes the WAL-related Valgrind
> suppressions. The regression tests pass under Valgrind with these
> changes.
I think I'm making some unneeded changes here though. For example in
ginxlogInsertListPage for a two-int struct with no padding. I'll need
to check them again one by one.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniil Davydov | 2026-03-11 11:28:30 | Re: POC: Parallel processing of indexes in autovacuum |
| Previous Message | Henson Choi | 2026-03-11 10:54:09 | Re: SQL Property Graph Queries (SQL/PGQ) |