From: | Shubham Barai <shubhambaraiss(at)gmail(dot)com> |
---|---|
To: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Borodin <amborodin86(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)gmail(dot)com> |
Subject: | Re: GSoC 2017: weekly progress reports (week 6) |
Date: | 2017-10-01 08:53:58 |
Message-ID: | CALxAEPvEUjZ10-uELtoKdebBX-3KPN2Ub=7gJypaf7HQzNjuKg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-www |
On 1 October 2017 at 01:47, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
wrote:
> On Sat, Sep 30, 2017 at 6:12 PM, Shubham Barai <shubhambaraiss(at)gmail(dot)com>
> wrote:
>
>> I have made changes according to your suggestions. Please have a look at
>> the updated patch.
>> I am also considering your suggestions for my other patches also. But, I
>> will need some time to
>> make changes as I am currently busy doing my master's.
>>
>
> I don't understand why sometimes you call PredicateLockPage() only when
> fast update is off. For example:
>
> @@ -94,6 +101,9 @@ scanPostingTree(Relation index, GinScanEntry scanEntry,
>> break; /* no more pages */
>>
>> buffer = ginStepRight(buffer, index, GIN_SHARE);
>> +
>> + if (!GinGetUseFastUpdate(index))
>> + PredicateLockPage(index, BufferGetBlockNumber(buffer), snapshot);
>> }
>>
>> UnlockReleaseBuffer(buffer);
>
>
> But sometimes you call PredicateLockPage() unconditionally.
>
> @@ -131,6 +141,8 @@ collectMatchBitmap(GinBtreeData *btree, GinBtreeStack
>> *stack,
>> attnum = scanEntry->attnum;
>> attr = btree->ginstate->origTupdesc->attrs[attnum - 1];
>>
>> + PredicateLockPage(btree->index, stack->buffer, snapshot);
>> +
>> for (;;)
>> {
>> Page page;
>
>
> As I understand, all page-level predicate locking should happen only when
> fast update is off.
>
> Also, despite general idea is described in README-SSI, in-code comments
> would be useful.
>
>
Hi Alexander,
Yes, page-level predicate locking should happen only when fast update is
off.
Actually, I forgot to put conditions in updated patch. Does everything else
look ok ?
Kind Regards,
Shubham
>
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2017-10-01 09:42:14 | Re: why subplan is 10x faster then function? |
Previous Message | Michael Paquier | 2017-10-01 08:45:57 | Re: [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2017-10-02 07:45:50 | Fix typo in CF App confirm dialog |
Previous Message | Alexander Korotkov | 2017-09-30 20:17:22 | Re: GSoC 2017: weekly progress reports (week 6) |