| From: | Ted Yu <yuzhihong(at)gmail(dot)com> |
|---|---|
| To: | akorotkov(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: checking snapshot argument for index_beginscan |
| Date: | 2022-12-22 20:35:59 |
| Message-ID: | CALte62y1qY8XDM0X42gq8a3ECMuoPaQWB8KBxu0FXkwz4wGF8Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> Hi,
> I was looking at commit 941aa6a6268a6a66f6895401aad6b5329111d412 .
>
> I think it would be better to move the assertion into
> `index_beginscan_internal` because it is called by index_beginscan
> and index_beginscan_bitmap
>
> In the future, when a new variant of `index_beginscan_XX` is added, the
> assertion would be effective for the new variant.
>
> Please let me know what you think.
>
> Cheers
>
| Attachment | Content-Type | Size |
|---|---|---|
| index-begin-scan-check-snapshot.patch | application/octet-stream | 920 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2022-12-22 21:13:50 | Re: checking snapshot argument for index_beginscan |
| Previous Message | Pavel Stehule | 2022-12-22 19:45:57 | Re: Schema variables - new implementation for Postgres 15 (typo) |