| From: | Ted Yu <yuzhihong(at)gmail(dot)com> |
|---|---|
| To: | Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Operation log for major operations |
| Date: | 2023-01-19 21:36:24 |
| Message-ID: | CALte62x_3x4LyFDS3CEtQBBmALFayLTheMQ_swMs7YDprEu4xQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 19, 2023 at 1:12 PM Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru> wrote:
> >The patch does not apply on top of HEAD ...
>
> Thanks!
> Here is a fixed version.
>
> Additional changes:
> 1) get_operation_log() function doesn't create empty operation log file;
> 2) removed extra unlink() call.
>
> --
> With best regards,
> Dmitry Koval
>
> Postgres Professional: http://postgrespro.com
Hi,
Copyright (c) 1996-2022
Please update year for the license in pg_controllog.c
+check_file_exists(const char *datadir, const char *path)
There is existing helper function such as:
src/backend/utils/fmgr/dfmgr.c:static bool file_exists(const char *name);
Is it possible to reuse that code ?
Cheers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2023-01-19 21:36:41 | Re: Decoupling antiwraparound autovacuum from special rules around auto cancellation |
| Previous Message | Melanie Plageman | 2023-01-19 21:28:59 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |