| From: | Ted Yu <yuzhihong(at)gmail(dot)com> |
|---|---|
| To: | Mikhail Gribkov <youzhick(at)gmail(dot)com> |
| Cc: | Nikita Malakhov <hukutoc(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>, Ivan Panchenko <wao(at)mail(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: On login trigger: take three |
| Date: | 2022-12-17 12:29:17 |
| Message-ID: | CALte62wg7NC2cS+KoojuvK7VTn0qdY+O6Q2mTLgw8Oc-yab5BQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Dec 17, 2022 at 3:46 AM Mikhail Gribkov <youzhick(at)gmail(dot)com> wrote:
> Hi Nikita,
>
> > Mikhail, I've checked the patch and previous discussion,
> > the condition mentioned earlier is still actual:
>
> Thanks for pointing this out! My bad, I forgot to fix the documentation
> example.
> Attached v34 has this issue fixed, as well as a couple other problems with
> the example code.
>
> --
> best regards,
> Mikhail A. Gribkov
>
Hi,
bq. in to the system
'in to' -> into
bq. Any bugs in a trigger procedure
Any bugs -> Any bug
+ if (event == EVT_Login)
+ dbgtag = CMDTAG_LOGIN;
+ else
+ dbgtag = CreateCommandTag(parsetree);
The same snippet appears more than once. It seems CMDTAG_LOGIN handling can
be moved into `CreateCommandTag`.
Cheers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ted Yu | 2022-12-17 12:39:29 | Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX |
| Previous Message | Amit Kapila | 2022-12-17 12:15:50 | Re: Perform streaming logical transactions by background workers and parallel apply |