Re: can we add subscription TAP test option "vcregress subscriptioncheck" for MSVC builds?

On Mon, Oct 18, 2021 at 6:19 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> > Thanks for your opinion. IIUC, the subscription tests can be run with
> > setting environment variables PROVE_FLAGS, PROVE_TESTS and the
> > "vcregress taptest" command right? I failed to set the environment
> > variables appropriately and couldn't run. Can you please let me know
> > the right way to run the test?
>
> No extra environment flags should be required for MSVC.
>
> This should suffice:
>
> vcregress taptest src/test/subscription

Wow! This is so simple that I imagined.

> If you want to set PROVE_FLAGS the simplest thing is just to set it in
> the environment before the above invocation

Okay.

> > If any test can be run with a set of environment flags and "vcregress
> > taptest" command, then in the first place, it doesn't make sense to
> > have recoverycheck, upgragecheck and so on. Another thing is that the
> > list of "vcregress" commands cover almost all the tests core, tap,
> > bin, isolation, contrib tests except, subscription tests. If we add
> > "vcregress subscrtptioncheck", the list of tests that can be run with
> > the "vcregress" command will be complete without having to depend on
> > the environment variables.
>
> The reason we have some of those other tests is because we didn't start
> with having a generic taptest command in vcregress.pl. So they are
> simply legacy code. But that is no reason for adding to them.

I get it, thanks.

> > IMHO, we can have "vcregress subscriptioncheck" to make it complete
> > and easier for the user to run those tests. However, let's hear what
> > other hackers have to say about this.
>
> I really fail to see how the invocation above is in any sense
> significantly more complicated.

Yes, the command "vcregress taptest src/test/subscription" is simple enough.

> > Another thing I noticed is that we don't have any mention of
> > "vcregress taptest" command in the docs [1], if I read the docs
> > correctly. How about we have it along with a sample example on how to
> > run a specific TAP tests with it in the docs?
> >
> > [1] - https://www.postgresql.org/docs/current/install-windows-full.html
>
> Yes, that's probably something that should be remedied.

Yes, I will prepare a patch for it.

Regards,
Bharath Rupireddy.