| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve GetConfigOptionValues function |
| Date: | 2023-01-23 10:48:20 |
| Message-ID: | CALj2ACXtr88wPrwJT8_QJjKgibXAaOBXgnRFK36XQ1jEUJWJzg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 23, 2023 at 3:29 PM Nitin Jadhav
<nitinjadhavpostgres(at)gmail(dot)com> wrote:
>
> > The v2 patch looks good to me except the comment around
> > ConfigOptionIsShowable() which is too verbose. How about just "Return
> > whether the GUC variable is visible or not."?
>
> Sounds good. Updated in the v3 patch attached.
>
> > I think you can add it to CF, if not done, to not lose track of it.
>
> Added https://commitfest.postgresql.org/42/4140/
LGTM. I've marked it RfC.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2023-01-23 10:56:20 | Re: run pgindent on a regular basis / scripted manner |
| Previous Message | Amit Kapila | 2023-01-23 10:44:44 | Re: Time delayed LR (WAS Re: logical replication restrictions) |