Re: correct the sizes of values and nulls arrays in pg_control_checkpoint

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Euler Taveira <euler(at)eulerto(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: correct the sizes of values and nulls arrays in pg_control_checkpoint
Date: 2021-12-23 15:46:02
Message-ID: CALj2ACXrDr5EN0uABDPSb0af8JOn1WQG8CBXX0GFRc4eBEuXEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 23, 2021 at 9:13 PM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>
> On Thu, Dec 23, 2021, at 8:39 AM, Bharath Rupireddy wrote:
>
> pg_control_checkpoint emits 18 columns whereas the values and nulls
> arrays are defined to be of size 19. Although it's not critical,
> attaching a tiny patch to fix this.
>
> Good catch! I'm wondering if a constant wouldn't be useful for such case.

Thanks. I thought of having a macro, but it creates a lot of diff with
the previous versions as we have to change for other pg_control_XXX
functions.

Regards,
Bharath Rupireddy.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Euler Taveira 2021-12-23 15:54:41 Re: Delay the variable initialization in get_rel_sync_entry
Previous Message Euler Taveira 2021-12-23 15:43:02 Re: correct the sizes of values and nulls arrays in pg_control_checkpoint