Re: [PATCH] Fix NULL dereference in subscription REFRESH on concurrent DROP

Hi,

On Sun, May 31, 2026 at 11:30 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> I've reviewed the patch and it looks good

Thanks Satya for the off-list discussion, and thanks Ajin for the review.

> just a small comment - instead of silently continuing after finding a dropped local table, would you want to log an error message?

IMHO, logging a message is unnecessary. The origin check only raises a
WARNING and doesn't drive the actual refresh, so silently skipping a
concurrently dropped relation is harmless.

A similar fix for concurrent relation drops in
pg_get_publication_tables() is in commit 63e7a0d2c, and I'm following
it in using try_table_open() and in not logging for dropped local
relations.

Please find attached the v2 patch. It has the following changes:

1/ Uses try_table_open() for all relations and gets the namespace
using RelationGetNamespace().
2/ Deduplicates the common code that quotes the subscription
relations' schema-qualified names for tables and sequences into a
helper function.
3/ Adds a TAP test with an injection point in 0002 (which I don't
intend to be committed).

We may need to backpatch the tables and sequences fix down to PG19,
and just the tables fix down to PG16 (commit 8756930190).

Thoughts?

--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com