From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Why is specifying oids = false multiple times in create table is silently ignored? |
Date: | 2021-04-07 13:25:04 |
Message-ID: | CALj2ACXZmaJORzJ=-==oK89VDfBWdwVseZ38FKt2B_wD-nuwtg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Apr 7, 2021 at 4:20 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Apr 07, 2021 at 04:00:46PM +0530, Bharath Rupireddy wrote:
> > And also, the commit 578b229718 talks about removing "with (oids =
> > false)" someday. Is it the time now to remove that and error out with
> > "unrecognized parameter "oids""?
>
> Nope, and I think that it will remain around for some time. Keeping
> around the code necessary to silence WITH OIDS has no real maintenance
> cost, and removing it could easily break applications. So there is
> little gain in cleaning up that, and a lot of potential loss for
> users.
I agree to not remove "with (oids = false)". At least shouldn't we fix
the "create table ... with (oids = false, oids = false ....)" case,
just to be consistent with other options?
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2021-04-07 13:32:55 | Re: SSL SNI |
Previous Message | Bharath Rupireddy | 2021-04-07 13:21:49 | Re: CREATE SEQUENCE with RESTART option |