| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Release replication slot on error in SQL-callable slot functions |
| Date: | 2026-08-05 18:15:00 |
| Message-ID: | CALj2ACXW2W_WXvssH_0-1s9MjAiPC1Ey7U_MOD+6HUupRy+Xdw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, Aug 4, 2026 at 8:37 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> > Right, I've confirmed that this can't happen. I'm OK with keeping this code,
> > since it's future-proof - otherwise, others might raise the same concern I
> > imagined above.
> >
>
> Okay, works for me, let's retain it. But good to change the comment to
> indicate there is no such scenario at the moment, otherwise it may
> confuse readers.
Agreed.
Please find the attached v8 patch.
--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Fix-replication-slot-leak-on-error-caught-in-a-su.patch | application/x-patch | 17.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-08-05 18:18:55 | Re: convert various variables to atomics |
| Previous Message | Peter Eisentraut | 2026-08-05 18:10:59 | Re: Update our timezone code to IANA tzcode2026b |