| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | japin <japinli(at)hotmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW |
| Date: | 2021-01-09 01:38:15 |
| Message-ID: | CALj2ACXTQzEVhCO_dQ0JDPj=_vKf5NsSvLrPa9J1P13FiPEtwA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 8, 2021 at 9:50 PM japin <japinli(at)hotmail(dot)com> wrote:
> > Attaching v3 patches, please consider these for further review.
> >
>
> I find that both the declaration and definition of match_matview_with_new_data()
> have a tab between type and variable. We can use pgindent to fix it.
> What do you think?
>
>
> static void
> match_matview_with_new_data(RefreshMatViewStmt *stmt, Relation matviewRel,
> ^
> Oid matviewOid, Oid OIDNewHeap, Oid relowner,
> int save_sec_context, char relpersistence,
> uint64 processed)
> ^
I ran pgindent on 0001 patch to fix the above. 0002 patch has no
changes. If I'm correct, pgindent will be run periodically on master.
Attaching v4 patch set for further review.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Rearrange-Refresh-Mat-View-Code.patch | application/octet-stream | 18.1 KB |
| v4-0002-EXPLAIN-EXPLAIN-ANALYZE-REFRESH-MATERIALIZED-VIEW.patch | application/octet-stream | 16.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-01-09 01:46:46 | Re: Improper use about DatumGetInt32 |
| Previous Message | Bharath Rupireddy | 2021-01-09 01:12:26 | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |