Re: Adding doubly linked list type which stores the number of items in the list

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com>
Subject: Re: Adding doubly linked list type which stores the number of items in the list
Date: 2022-11-03 07:41:06
Message-ID: CALj2ACXOR5WwATM5sezBJKT-fUgki6yOvtyPtFiojnu1Q+_MpQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 2, 2022 at 2:23 PM Aleksander Alekseev
<aleksander(at)timescale(dot)com> wrote:
>
> Hi David,
>
> > Pushed. Thank you both for reviewing this.
>
> Thanks for applying the patch.
>
> >> Should we consider const'ifying the arguments of the dlist_*/dclist_*
> >> functions that don't change the arguments?
> >> [...]
> > You're right, both of them must be discussed separately.
>
> I would like to piggyback on this thread to propose the const'ifying
> patch, if that's OK. Here it is.

Thanks for the patch. IMO, this can be discussed in a separate thread
to get more thoughts from the hackers.

BTW, there's proclist_* data structure which might need the similar
const'ifying.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ian Lawrence Barwick 2022-11-03 07:51:13 Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)
Previous Message Peter Smith 2022-11-03 07:40:59 Re: Support logical replication of DDLs